-
Notifications
You must be signed in to change notification settings - Fork 526
[win][arm64ec] Fix finding assembler and setting is_arm for Arm64EC #1511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Just one refactor required
5e70630
to
281ec7c
Compare
281ec7c
to
b7bb0c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Seems like it break the ci on main https://github.com/rust-lang/cc-rs/actions/runs/16855945795/job/47749185799#step:6:1 |
Errr... doesn't seem related to my change. It shouldn't have affected non-MSVC targets... |
Hmm... This is for build-std with nightly, did something break in the Rust project? |
Maybe? i was thinking if there's some |
Took another look, you are right, it's probably a nightly issue |
Looks like those compiler warnings were red herrings, the real error is:
|
I believe the root cause is rust-lang/rust#139451 (cc @madsmtm) Seems that Lines 33 to 47 in ca81dcc
@wesleywiser can we do a crater run with nightly? Seems like this is a breaking change... Guessing the fix in cc is to check both |
Fixed in #1517 |
Thank you for finding the rust PR for me! |
I don't think a crater run will really find anything as it effectively can only test I agree there's a compatibility concern here but that was disclosed on rust-lang/rust#139451 and the compiler team FCP'd the change. I'll make sure we have a release note for that. |
No description provided.